add stats videojs plugin #3958
Merged
add stats videojs plugin #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelk
added
UI
rigelk
force-pushed
the
stats-for-nerds
branch
2 times, most recently
from
22faed0 to
0af362b
Compare
rigelk
commented
Apr 15, 2021
Comment on lines
159
to
166
| if (this.source === 'webtorrent') { | ||
| const progress = this.player_.webtorrent().getTorrent()?.progress | ||
| const videoFile = this.player_.webtorrent().getCurrentVideoFile() | ||
| videoFile.metadata = metadata[videoFile.fileUrl] = videoFile.metadata || metadata[videoFile.fileUrl] || videoFile.metadataUrl && await fetch(videoFile.metadataUrl).then(res => res.json()) | ||
| this.list.innerHTML = getListTemplate(this.options_, this.player_, { playerNetworkInfo: this.playerNetworkInfo, videoFile, progress }) | ||
| } else { | ||
| this.list.innerHTML = getListTemplate(this.options_, this.player_, { playerNetworkInfo: this.playerNetworkInfo }) | ||
| } |
There was a problem hiding this comment.
@Chocobozzz I'm wondering how to get the current progress of buffered data, and more importantly the current video file in the case of p2p-media-loader use; I searched through the code, to no avail 😢
There was a problem hiding this comment.
I think you need to give the ability to provide the hlsjs object in the p2p-media-loader-plugin.ts so you can get it here and use all available information
Chocobozzz
force-pushed
the
stats-for-nerds
branch
from
0b17f4c to
cc9a2f5
Compare
Chocobozzz
force-pushed
the
stats-for-nerds
branch
from
cc9a2f5 to
b184ac2
Compare
Chocobozzz
force-pushed
the
stats-for-nerds
branch
from
b184ac2 to
8a324ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a "stats for nerds" panel, like YouTube provides, minus a few things: no mystery text, no exposure of an optimal resolution, no loudness normalization (we don't have that yet), no fancy graphs (yet).
It serves as a good debug tool for advanced users, where we could move some of the information we currently display in the bar (like p2p traffic) - taking precious space.
Related issues
closes #1788
Has this been tested?
TODO:
Screenshots
Don't mind the fluffy cat 😉